Closed yobrx closed 13 years ago
That's great and all, but seeing that Diem is or should be a community effort, and quite some members of the community don't understand French that well, could we agree on making pull requests etc English only? :)
Yes, sorry... my post was originally for Stephane after a demand of pull on Twitter. I will make a translation tonight ! (I working now)
Please note, there are in this pull :
$this->embedRelationDynamic('EventSchedules as event_schedules', 'EmbedEventSchedulesAdminForm');
And the embedded class :
class EmbedEventSchedulesAdminForm extends BaseEventScheduleForm
{
public function configure()
{
parent::configure();
unset($this['event_id'], $this['created_at'], $this['updated_at']);
}
}
Then add "event_schedules" in admin generator.yml, and it's OK !
In contrast, add N medias is not finalized ... For now, you must name the field dm_media_id on the join table. (EventSchedules in our example). And the code is not very clean...
Sorry for my English if it is not understandable, it's much easier to read than to write :)
That's great! However I don't know how useful are the getters in Yophp/diem@231f5b805df3a4c649388effafdb884acdc8298e ? Especially replicated in two classes.
Can you also revert the temporary ajaxDialog
fix at Yophp/diem@bcac464428c9be4a520a754c09425b5b6e893cb8 . It's fixed by lowering the z-index.
The getters are shorcuts for get record, record id or record model of a page in a action and a component.
For Yophp/diem@bcac464, ok, i cancel this
It's already cancelled : Yophp/diem@e7c9b1a ;)
You said N-relations is not finished. Wouldn't it be better to create a different branch until it's resolved.
This:
dm_media_id
will confuse new developers.
Stephane, Eric, Kye , any suggestions?
@Yophp, I've asked Kye, and it's better for the N-to-N functionality to be as a plugin.
Right now I can cherry-pick only the other commits but it would be best if you move N-to-N functionality out of the master
so that we can keep the ability to merge future requests from you
Hmmm ok for the plugin, but it would tell me how I can override the methods of dmFormDoctrine class in a plugin, form classes to extend BaseFormDoctrine (copied to the project), and dmFormDoctrine extends to BaseFormDoctrine.
I need your help on this subjec t:)
Attention, j'attire ton attention sur le fait qu'il y a dans ce pull :
Et la classe "embedded" :
Ajouter ensuite "event_schedules" dans l'admin generator.yml, et c'est bon :) Par contre les N médias ne sont pas encore finalisés... il faut obligatoirement, pour l'instant, nommer le champ dm_media_id sur la table jointe. (EventSchedules dans notre exemple). Et le code n'est pas très très propre...