search

diem-project / diem

Diem CMF CMS for symfony 1.4
http://diem-project.org/
MIT License
184 stars 85 forks source link

small style change regarding editing widgets on front #417

Open ardi-n opened 12 years ago

ardi-n commented 12 years ago

I would suggest to disable border for highlighted widgets because it brakes layout of the page. Instead we can use 

#dm_page.edit .dm_widget .dm_widget_inner {
  outline: 2px groove #D3D3D3;
  border: none;
/*  border-radius: 0 4px 4px 4px;
  -moz-border-radius: 0 4px 4px 4px;
  -webkit-border-radius: 0 4px 4px 4px;*/
}

outline does not change box model.

TheCelavi commented 11 years ago

I do not see the reason for this... rejected, sorry.

jrencz commented 11 years ago

ardi-n: I do the same in each of my diem installs. IMO you're right - diem should not break the layout.

TheCelavi commented 11 years ago

Ok, I see, but why not for Zone as well? Pull fix so we can merge it.

eXtreme commented 11 years ago

It will break anyway because the "widget" handle is shown as well.

I fix this adding additionals CSS which disables floats and positions in edit mode to make it look "right".

jrencz commented 11 years ago

Off course both widget and zone need to be restyled. In my case I changed 'widget' and 'zone' "tags" into little 1/4-circles with 'W' and 'Z' in it. They're placed in left and right corner respectingly. Coupled with border-to-outline change it does the thing. No dimension is changed in edit mode at all

jrencz commented 11 years ago

hmmm... seems like I can post an image too: Screenshot 2012-12-08 at 23.05.21.png here you can see widget with no body in zone which has slightly dimmed body in edit mode only

eXtreme commented 11 years ago

@jrencz can you share the code for that? Or is it just a concept? Because a widget div will overlay zone div making it impossible to click on "Z" to edit the zone

jrencz commented 11 years ago

@eXtreme sure I do ;) And it's clickable. Should I make a pull request? Probably it's not ready for merging with Diem yet or anyway. Maybe the right way is to make a plugin. I'll try to rewrite it into a plugin during Christmas break. Feel free to contact if you want to help: jrencz@polibuda.info

eXtreme commented 11 years ago

PR would be great, I'd like to test it myself.

TheCelavi commented 11 years ago

@jrncs Would you be so kind and share your solution for this with us?

jrencz commented 11 years ago

sorry, but I had (and for netx 3 weeks won't have probably) any time to separate it form my project. It'll either have to wait or be closed for now