search

diem-project / diem

Diem CMF CMS for symfony 1.4
http://diem-project.org/
MIT License
184 stars 85 forks source link

php7-compat #442

Open thehe opened 8 years ago

thehe commented 8 years ago

just basic php7 compatibility

jrencz commented 8 years ago

could you please remove cursing from commit logs?

thehe commented 8 years ago

hey guys,

  1. sorry - thought i pushed into my private repo!
  2. no - no REAL hardcoding, it's just because you're only importing i18n-seed-data (basic translations) if there are MORE than one language and language is default! if you just set 'de' for example, you won't get any translation for the backend.

A collegue and me thought that this would be the "smallest possibile fix" for this issue and we don't want to spend too much time in diem - projects seems more than dead. (for example the "plugins"-pages on diem-project.org are unavailable since months).

regards

4levels commented 8 years ago

I've added some of your changes in the master branch (eg. de deprecation warnings since php > 5.6). I've also updated the symfony submodule (merged changes from forked origin and some PR's regarding deprecation warning). I'd love to merge your PR but there are still some issues..

thehe commented 8 years ago

Hey - for sure there are some conflicts, i don't wanted to produce conflicts... This variable can be deleted, yes, but I didn't get, what it did BEFORE my changes, so i thought, that someone who knows, should decide, how to handle this...