Update dip-1.mdx - Githubissues

davidiw commented 3 years ago

Make the reference and cid must and instead of should, it seems a little strange that in other cases we are very clear about format and shape and in this case we offer flexibility
clean up language like (bytes, ASCII) that's just bytes and bytes, hex is hex-encoded bytes
subaddress is now address / participant where appropriate
do not use uleb-128 for onchain metadata representation of the ref id since it doesn't compress it actually expands the data and just adds more complexity to this protocol

aching commented 3 years ago

Is this PR still active, or is the thought to create a new DIP that obsoletes DIP-1?

davidiw commented 3 years ago

Is this PR still active, or is the thought to create a new DIP that obsoletes DIP-1?

closing out will update with something shortly

diem / dip