search

diem / dip

Libra Improvement Proposals
https://lip.libra.org
Apache License 2.0
40 stars 55 forks source link

Update lip-8 #75

Closed danprinz closed 3 years ago

danprinz commented 3 years ago

Disclaimer regarding the discovery phase Extended scope for fund pull pre-approval Revoke an authorization in more details

bors-libra commented 3 years ago

:exclamation: before this PR can be merged please make sure that you enable "Allow edits from maintainers".

This is needed for tooling to be able to update this PR in-place so that Github can properly recognize and mark it as merged once its merged into the upstream branch

JoelMarcey commented 3 years ago

@danprinz Looks like a rebase may be needed.

@bmwill Is there something we need to do with bors here? I don't usually see that warning in PRs to this repo, I don't think.

bmwill commented 3 years ago

@JoelMarcey Did we ever resolve if we wanted bors on this repo or not? If not I probably need to just disable bors since IIRC we aren't currently relying on bors for this repo.

JoelMarcey commented 3 years ago

@bmwill I think I am ok removing bors on this repo for now and revisit later. We have the passive checks to make sure the website builds and we have only CODEOWNERS being able to merge, which helps too.

kphfb commented 3 years ago

Think with the one change I suggest, it hopefully addresses https://github.com/libra/lip/issues/71 as well. If so, we can close that one once this is updated

kphfb commented 3 years ago

I think I'm mostly good with this PR other than I'm still not convinced about "type" and want to chat about that first

davidiw commented 3 years ago

feel free to re-open but this is pretty stale now