search

diesdasdigital / kirby-meta-knight

🔍 Meta Knight – SEO & Social Media Sharing Plugin for Kirby.
MIT License
109 stars 18 forks source link

Version 1.2.1 stopped working on single language pages #48

Closed skyeewers closed 2 years ago

skyeewers commented 3 years ago

Since updating from version 1.2 to 1.2.1 of meta knight it appears as though the plugin has stopped working on single-language Kirby instances. Every frontend page starts throwing http 500 errors after the update.

The issue appears to be in meta_information.php:61 where you call $page->url($kirby->defaultLanguage()->code()). But since $kirby->defaultLanguage() is null on single-language Kirby instances, you're just generating a non-recoverable error here.

Here's the full log of errors I'm getting on one of my Kirby instances with 1.2.1 of meta-knight

Screenshot 2021-10-23 at 14 09 42
skyeewers commented 2 years ago

Fixed in release 1.2.2. Thanks everyone!