More code reviewers wanted!

[sgrif]

With the push to 1.0, the current pool of reviewers is starting to run low on bandwidth. We're looking for more people to help get involved with code review. You don't need to be familiar with Diesel's internals to help. Most people who have been on the Diesel core team got started by doing code review. If you're unsure what a piece of code does or why it's being done a certain way, just ask! (Make sure that the commit message doesn't answer that question already though). Don't feel like you can't ask a question just because other reviewers might already know the answer. We're happy to help you get up to speed.

[weiznich]

@deepu9 I added you to the corresponding team. You should now get a ping each time there is a review necessary. Feel free to ask any question at a PR, even if it's not related to the PR itself. I will try to answer them. Otherwise #3087, #3090 and #3092 are in progress PR's that coud get additional reviews. Feel free to reach out if anything about any part of the code is unclear.

[czotomo]

@weiznich I'd like to get pinged, too. I can't promise to always have great insight for a PR because I'm still a Rust toddler, but I'll do my best

[weiznich]

@czotomo I've send you an invitation as well. Feel free to take a look at any PR. As mentioned multiple time above: It's totally fine not to understand everything and also to use the review as exercise to learn more about rust. This explicitly includes asking questions about code patterns you haven't seen anywhere yet or even uncommon syntax. It's also fine if such questions are not related to the actual PR.

[phillyphil91]

Hi. I would also like to be added to the PR reviewers list if that is still open. Thanks

[weiznich]

@phillyphil91 I've send you an an invitation. Feel free to take a look at any PR. As mentioned multiple time above: It's totally fine not to understand everything and also to use the review as exercise to learn more about rust. This explicitly includes asking questions about code patterns you haven't seen anywhere yet or even uncommon syntax. It's also fine if such questions are not related to the actual PR.

For the record: https://github.com/diesel-rs/diesel/pull/3213 is the current WIP PR.

[JeremyLARDENOIS]

Hello, I'm new to rust and diesel but I want to help. Is it possible to be added?

[weiznich]

@JeremyLARDENOIS We always look for new reviewers! I've send you an an invitation. Feel free to take a look at any PR. As mentioned multiple time above: It's totally fine not to understand everything and also to use the review as exercise to learn more about rust. This explicitly includes asking questions about code patterns you haven't seen anywhere yet or even uncommon syntax. It's also fine if such questions are not related to the actual PR.

[JeremyLARDENOIS]

Ok no problem, thank you!

[JeremyLARDENOIS]

Hello, I was looking at some PR, but I was asking myself how should I review them (I'm a beginner, sorry). In your opinion, what is a correct review? Is it to read the code, try understanding how it solves an issue, and test it ? Test the code, is it only do a cargo test? (sorry if I'm wrong)

[weiznich]

@JeremyLARDENOIS First of all: It's totally fine to ask such questions. There is no need to be sorry about that.

As for how to review a PR: You basically look at the code and try to understand what it does. At that point: Just add comments to the PR for parts that you don't understand or that look somehow strange. Its also totally fine to ask about rust constructs you are unfamiliar with or about other parts of diesel or whatever is unclear in some context. We generally try to answer such questions in these code reviews as well. You don't need to checkout the code locally and run the tests. That's already covered by our CI setup, so it's normally sufficient to check if the CI passes to get a general feeling if the code passes tests or not.

[JosueMolinaMorales]

Are you still looking for code reviewers? Started learning rust over a year ago and wanted to learn more by contributing to open source projects.

[weiznich]

@JosueMolinaMorales We always look for help with code reviews. I've added you to the corresponding team, so that you get a notification as soon as something needs an review. Feel free to take a look at any PR. As mentioned multiple time above: It's totally fine not to understand everything and also to use the review as exercise to learn more about rust. This explicitly includes asking questions about code patterns you haven't seen anywhere yet or even uncommon syntax. It's also fine if such questions are not related to the actual PR.

[matthewreader]

Are you still looking for code reviewers? I started learning rust recently and have been able to build some simple APIs with actix-web and have a little knowledge of diesel and sqlx. By no means a rust expert, just trying to find an open source project to contribute to and think rust is a neat language.

[weiznich]

@matthewreader We are always looking for more reviewers. I just send you an invitation. As already written above: It's totally fine to use these reviews to get a better understanding of rust (and some advanced trait level things used by diesel). You can ask questions about anything that's unclear during reviews, even if that's not strictly related to a given PR. I will try to answer them. https://github.com/diesel-rs/diesel/pull/3560 or https://github.com/diesel-rs/diesel/pull/3561 are two PR's that waiting for an review and might be good places to start.

[hasnainzeenwala]

Hi! I'd like to get involved in code reviews. I have used Diesel for work and loved it. I want to gain a deep enough understanding of its internals to be able to contribute to the project and this seems like a good place to start. Thanks.

[weiznich]

@hasnainzeenwala I just send you an invitation. As written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works. https://github.com/diesel-rs/diesel/pull/3622 is one of the PR's that are likely a good starting point.

[hasnainzeenwala]

Thanks @weiznich. Will take a look at that PR.

[weiznich]

@hasnainzeenwala Seems like you found the invitation, because github shows that you joined the relevant team. For new PR's you should now get notifications if a review is requested.

[hasnainzeenwala]

@weiznich yup saw that I had received it. That's why removed my comment.

[jporwal05]

Hi Team, I would like to get involved in the code reviews as well. I want to get better understanding of Diesel and want to be an active contributor to this project. Thank you!

[weiznich]

@jporwal05 Thanks for your interest. I've sent you an invitation for the reviewers team. If you join that team you get notifications for each PR where a review is requested. As written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works.

[jporwal05]

Yes @weiznich ! Thanks for the warm welcome!

[AlexStorm1313]

Hey, still looking for volunteers? I would like to gain open-source collaboration experience and rust knowledge. Using this project myself I'm also open to write documentation/cookbooks in the future.

[weiznich]

@AlexStorm1313 Thanks for your interest. I've sent you an invitation for the reviewers team. If you join that team you get notifications for each PR where a review is requested. While https://github.com/diesel-rs/diesel/pull/3783 is a bit larger it might be a good starting point. As written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works.

[shellcodesniper]

still looking for volunteers? I'd hope to particifate..

[weiznich]

@shellcodesniper Thanks for your interest. We are always looking for more code reviewers. I've sent you an invitation for the reviewers team. If you join that team you get notifications for each PR where a review is requested. While https://github.com/diesel-rs/diesel/pull/3783 is a bit larger it might be a good starting point. As written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works.

[rustacean23]

Hi! Are you still looking for code reviewers? I am studying rust and wanted to learn more by contributing to open source projects.

[weiznich]

@rustacean23 Thanks for your interest. We are always looking for more code reviewers. I've sent you an invitation for the reviewers team. If you join that team you get notifications for each PR where a review is requested. The PR https://github.com/diesel-rs/diesel/pull/3837 is a good one to get started. As written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works and extend your rust knowledge.

[g-hi3]

Hi, are you still looking for code reviewers? I'm also interested in reviewing PRs.

[weiznich]

@g-hi3 We are still looking for code reviewers. I've sent you an invitation for the reviewers team. If you join that team you get notifications for each PR where a review is requested. While https://github.com/diesel-rs/diesel/pull/3783 is a bit larger it might be a good starting point. As written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works.

[pppp24]

Hi, would be happy to review some PRs as well if it's still possible to join ? I've got more theoretical knowledge of Rust than practice so would love to get more exposure to it

[weiznich]

@pppp24 I've sent you an invitation for the reviewers team. If you join that team you get notifications for each PR where a review is requested. https://github.com/diesel-rs/diesel/pull/3940 might be a good starting PR, although there are some review comments there. As written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works.

[pppp24]

thanks a lot @weiznich, I notice that #3940 has already been approved but will take a look at it regardless as well as the other recently approved/pending PRs that you requested review on (#3948 , #3949, #3951 )

[peasee]

I'd like to get involved in some reviews as well 😄 I'll help where I can in my spare time!

[weiznich]

@peasee That's really appreciated. I've added you to the relevant team so that you get a notification for PR's that wait for a review. https://github.com/diesel-rs/diesel/pull/3951 might be a good starting point.

Also as written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works.

[DavisRayM]

Hi, i'd like to help review PRs; I have beginner level understanding of Rust & would like to contribute/review to get a bit familiar with the language and codebase

[weiznich]

@DavisRayM I've set you an invitation to the reviewer team. If you join that team you get a notification every time a review is requested.https://github.com/diesel-rs/diesel_full_text_search/pull/41 might be a good starting point.

Also as written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works.

[ericbarrionuevo]

I'd be interested in jumpiing into some code reviews about commits in this repository, if you folks are still looking for people, thanks

[weiznich]

@samuelbarrionuevo We are always interested in more reviewers. I've sent you an invitation to relevant team.If you join that team you get a notification every time a review is requested.

https://github.com/diesel-rs/diesel/pull/4061 might be a good starting point.

Also as written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works.

[kw217]

Hi @weiznich, I saw the call for reviewers in the Diesel 2.2.0 announcement and I'd love to help. Please could you add me to the team? I'm fairly experienced at Rust and I've used Diesel for a few things over the years. Thanks.

[weiznich]

@kw217 Thanks for your interest. I've sent you an invitation to relevant team.If you join that team you get a notification every time a review is requested.

4064 might be a good starting point.

[kw217]

Thanks. Belated post-commit review added - LGTM, for what it's worth :-)

[guissalustiano]

Hi, i'd like to help review PRs; I have being helping with some functions and methods implementations and use diesel daily in my job. Thanks!

[weiznich]

@guissalustiano Thanks for your interest. Any help with reviewing PR's is welcome. As written above: Do not hesitate to ask questions about anything that's unclear during such reviews. It's one of the best possibilities to learn how diesel internally works.

Any of the recent array function PR's (#4186, #4187, #4190, #4191) is likely a good starting point.

[ndranathunga]

I'd like to get involved in some reviews as well. I'm relatively new to Rust and hoping to learn more by helping.

[cameron1024]

I'd also be keen to help review. Is there a group/mailing list I can be added to?

[weiznich]

@ndranathunga @cameron1024 Thanks for your interest. I've send you both an invitation to join the diesel/reviewer github team. That mostly notifies you if there is a new review requested. Otherwise as written before: Do not hesitate to ask questions about the code you are looking at, even if it seems to be not related to what the PR implements. I will try to answer them and that's a good way to learn more about rust and diesel.

Any of https://github.com/diesel-rs/diesel/pull/4202, https://github.com/diesel-rs/diesel/pull/4197 or https://github.com/diesel-rs/diesel/pull/4169 is likely a good starting point.

[wowinter13]

@weiznich hello there! Could you please add me to the reviewers list? Also want to have a finger on the pulse of the project :)

[weiznich]

@wowinter13 Thanks for your interest. I've added you as well, otherwise my comment from yesterday still remains accurate, so please to do not hesitate to ask any question that comes up.

[rienmack]

Hi @weiznich wondering if I could help out with some reviews and be added to the reviewers list? Thanks! :)