search

dieselrabbit / screenlogicpy

Interface for Pentair Screenlogic connected pool controllers over IP in Python
GNU General Public License v3.0
17 stars 5 forks source link

Circuits marked as "don't show" enumerate in HA #34

Closed American1337 closed 1 year ago

American1337 commented 1 year ago

I have a few circuits that are marked as "don't show" in the pentair desktop app yet enumerate in HA. I'm curious whether that is intended or not?

This might be not a bug as I can mark the entities as hidden myself using home assistant UI. But out of the box it is some clutter, up to you on whether this is a feature or bug. Interestingly Aux 7 doesn't show but the other aux 8/9/10 do show in HA, not sure why some are hidden and others are not.

circuits in HA:

image

My circuit config:

image image image

dieselrabbit commented 1 year ago

This is good info and a good bug. Naively, the HA integration adds-but-disables any circuit with a what is thought to be a generic default name. Based on the information I had at the time, this was Feature [1-8], Aux [1-7], and AuxEx. It was a best guess at removing some clutter from the initial setup. With your info, I've expanded this to Aux [1-23], but it also shouldn't be a problem to respect the "Don't Show" setting from the pool controller. There's work to be done here in the api, but also in the HA integration.

One question: The previous data I have from you lists a different "Show on:" setting for U Pool Ligh and Fiber Optic that I haven't seen before. Are those set to something other than Pool, Spa, Lights, Features, or Don't Show?

American1337 commented 1 year ago

All the circuit names had to be reentered after the pentair system power loss/battery backup failed , so some have different names now.

"U Pool Ligh" is now "Upr Lite" (upper pool light).

But I think I had the same fiber optic name before and after.

dieselrabbit commented 1 year ago

For "Upr Lite" and "Fiber Optic", what is the "Show on:" set to?

American1337 commented 1 year ago

image image

dieselrabbit commented 1 year ago

Interesting. Not what I expected. Thanks.

dieselrabbit commented 1 year ago

Could you provide an updated diagnostic data?

American1337 commented 1 year ago

diagnostics.txt

dieselrabbit commented 1 year ago

I've identified the interface value for "Don't Show" and definition of that has been added to the code. screenlogicpy will need a new release and changes will need to be made in Home Assistant.

dieselrabbit commented 1 year ago

Fix will likely be available in 2023.3.0 of Home Assistant.