search

dieserRobin / canireact-extension

Browser Extension which displays reaction guidelines for a video or channel to streamers.
https://canireact.com
Creative Commons Zero v1.0 Universal
37 stars 1 forks source link

use browser defaults to parse urls #3

Closed MurmeltierS closed 2 months ago

MurmeltierS commented 2 months ago

hey, It's me again. I don't want to bother you, and feel free to share your opinion on this, but I stumbled upon your videoId parsing approach.

While I guess it should work fine for most cases, there are some edge cases that could be easily prevented by using the browser defaults.

e.g. opening a link with an anchor to the comments section https://www.youtube.com/watch?v=4-YXdvUs1_M#comments will parse as 4-YXdvUs1_M#comments with your approach.

I guess we can assume browser support für browsers without URL support is off the table.

dieserRobin commented 2 months ago

that's a good change, thanks again