search

diffCheckOrg / diffCheck

diffCheck is a CAD-integrated tool for evaluating digital timber fabrication processes.
https://diffcheckorg.github.io/diffCheck/
GNU General Public License v3.0
3 stars 2 forks source link

Broken code for `DF_cloud_mesh_distance` #123

Closed 9and3 closed 5 days ago

9and3 commented 1 week ago

Hello @eleniv3d, my bad I let this slide and merge it but the file code.py in DF_cloud_mesh_distance seems to be broken. In line 52-53 the siffed_ variables are not created, apparently it is missing.

Here's now: https://github.com/diffCheckOrg/diffCheck/blob/9734eea625995f1b73c36caca7368a7be84ef0c9/src/gh/components/DF_cloud_mesh_distance/code.py

And before: https://github.com/diffCheckOrg/diffCheck/blob/1bd5727c761b0d395685dc48f3e923794e9fda35/src/gh/components/DF_cloud_mesh_distance/code.py

Do you what's the correct fix for the siffed_ two variables now?

eleniv3d commented 1 week ago

it almost feels like it happened to me in a dream but I think it was left from an earlier idea of getting rid the Null pcd but we treat them differently now. I got rid of the shift in the CVS exporter PR which is coming in 5'