search

diffCheckOrg / diffCheck

diffCheck is a CAD-integrated tool for evaluating digital timber fabrication processes.
https://diffcheckorg.github.io/diffCheck/
GNU General Public License v3.0
3 stars 2 forks source link

Double check the transformation from df to rh #22

Closed 9and3 closed 1 month ago

9and3 commented 4 months ago 
          Are you sure this works ? The DFTransformation.RotationMatrix is a 3x3 matrix, so I don't understand what happens here. From the Rhino Common API i suppose you use this constructor : https://developer.rhino3d.com/api/rhinocommon/rhino.geometry.transform/rotation#(vector3d,vector3d,point3d) but rotation[1], rotation[2] and rotation[3] are not doubles or int, they should be lines of the matrix and rotation[3] should be out of range, so as I read it, it will not work as intended, but I am probably wrong.

_Originally posted by @DamienGilliard in https://github.com/diffCheckOrg/diffCheck/pull/18#discussion_r1615326772_

9and3 commented 4 months ago

to keep an eye on it or to double check if we got a sec @DamienGilliard

9and3 commented 1 month ago

closing due to inactivity