search

diffblue / 2ls

Static Analyzer and Verifier
http://www.cprover.org/2LS
Other
43 stars 22 forks source link

Replace TravisCI with Github Actions #153

Closed FrNecas closed 2 years ago

FrNecas commented 2 years ago

Since TravisCI is no longer free, we agreed with @viktormalik to migrate to Github Actions for CI purposes.

FrNecas commented 2 years ago

Hm, it's weird that there are no Github Actions checks on this pull request. Not sure if it has to be enabled somewhere (the checks seem to be running on my branch - see https://github.com/FrNecas/2ls/runs/3381779235 )

peterschrammel commented 2 years ago

Github actions always execute the workflow defined on the default branch. Otherwise, anyone can create a PR with a workflow and run anything.

peterschrammel commented 2 years ago

Is this ready to merge?

FrNecas commented 2 years ago

I'd say so unless we can somehow figure out what's wrong with the mac build. Or lets phrase it differently - are we fine with testing just under Ubuntu? Previously we tested on mac as well so this slightly reduces the robustness of our CI. I just don't know what's wrong with the build, the CBMC compilation fails ( see the trace https://github.com/diffblue/2ls/pull/153#discussion_r692902779 ). It looks like #include <fstream> fails to compile which is weird on its own. I don't have a mac so no way to play around with this. I've asked a friend who has one to try it and he got the same error though

peterschrammel commented 2 years ago

We can debug the mac issue separately.

peterschrammel commented 2 years ago

The linter job seems to have a problem. The ubuntu jobs work correctly. Tests are run and pass.

FrNecas commented 2 years ago

Yes, the problem occurrs only when the action is ran after pushing (merging in this case) to the master branch as it refuses to fetch - fixed here https://github.com/diffblue/2ls/pull/154