diffblue / cbmc

C Bounded Model Checker
https://diffblue.github.io/cbmc
Other
848 stars 264 forks source link

Review ait::initialize(goto_{programt,functiont}) #1848

Open tautschnig opened 6 years ago

tautschnig commented 6 years ago

ait has both void initialize(const goto_programt &); and void initialize(const goto_functionst::goto_functiont &);, where goto_functiont has very little additional information. This API should be reviewed so as the enable removal of goto_programt::get_function_id which currently has a single use case in dependence_grapht::initialize.

peterschrammel commented 6 years ago

goto_functiont should be made aware of its own name to actually add value and simplify interfaces.

martin-cs commented 6 years ago

I don't see a problem here.