differentiate-catalysis / catalyst-bubble-detection

Detect bubbles that are evolving gas from a catalyst surface to determine reaction rate
1 stars 0 forks source link

clean up, clarify, and condense options in `main.py` #36

Closed ascourtas closed 2 years ago

ascourtas commented 2 years ago

Currently, there are options in main.py that are not used or are redundant. Additionally, some just need more clarification in the help string.

For more granular notes on options that stood out, see the April 7th meeting notes https://docs.google.com/document/d/1yYnpvj9rA-Dpbx051P8SkkTA4315Pp7fqnz08x3tsyA/edit#heading=h.ikz31eidp5ot

The issue #37 will address adding if/else checks in the code to warn the user if they're using a combination of options that conflict, or are unnecessary

ascourtas commented 2 years ago

@jimtjames I assigned you since you started this work this week, but feel free to reassign as necessary

jimtjames commented 2 years ago

Cleaned some of these. Will need to modify the MatCNN submodule as well.

ascourtas commented 2 years ago

@jimtjames can you clarify where we're at on this one?

jimtjames commented 2 years ago

Ticked the corresponding boxes! This is almost done.