search

differentiate-catalysis / catalyst-bubble-detection

Detect bubbles that are evolving gas from a catalyst surface to determine reaction rate
1 stars 0 forks source link

Option condensing #46

Closed NathanPruyne closed 2 years ago

NathanPruyne commented 2 years ago

Reduces the number of options needed for argument checks largely by not using separate arguments for HPO runs. Also includes a few more docstrings scattered about.

NathanPruyne commented 2 years ago

@jimtjames is there a reason the argparser definitions are below the default args now?

jimtjames commented 2 years ago

Yes, that's so I can reference them in the help strings for the parser.

NathanPruyne commented 2 years ago

Added the new video_dir arg. I'll move it back down there (hi Jim lol)

NathanPruyne commented 2 years ago

wait I definitely messed it up, going to revert and redo this

jimtjames commented 2 years ago

Awesome. That arg should be slightly refactored (rn I have it being used in main, should move to evaluate).