search

differentiate-catalysis / catalyst-bubble-detection

Detect bubbles that are evolving gas from a catalyst surface to determine reaction rate
4 stars 0 forks source link

resolve issue with Kornia `permute()` #68

Open ascourtas opened 2 years ago

ascourtas commented 2 years ago

weird issue where permute() is messing up the image size and interfering with train/test and inference.

Aadit-Ambadkar commented 2 years ago

I think this is fixed right?

ascourtas commented 2 years ago

Nathan has a hotfix in main, but some additional fixes need to be added

NathanPruyne commented 2 years ago

Fixes need to be done for the apply_transforms method in conversions.py

Aadit-Ambadkar commented 2 years ago

so should I create a new branch off of main or off of dev?

NathanPruyne commented 2 years ago

Off of main. I'm not sure what dev is to be honest, I don't remember making it lol. Most "dev" style commits have been put in torchvision_rewrite (though I'm not sure why). If you wanted to just use dev (checkout dev and then do git rebase main to get it up to speed first though) that's cool too.