search

differentiate-catalysis / catalyst-bubble-detection

Detect bubbles that are evolving gas from a catalyst surface to determine reaction rate
1 stars 0 forks source link

Reduce NMS overhead #74

Open ascourtas opened 2 years ago

ascourtas commented 2 years ago

Optimize NMS usage by passing in an argument to the MaskRCNN and FasterRCNN constructors (they should have the right option) to set the NMS threshold. Then, remove the usage of our NMS call in the ML pipeline (but keep the function definition around for future usage).

What's currently happening is there's 1 NMS that's run within the constructor, and 1 that we run in our pipeline, which is redundant.

ascourtas commented 2 years ago

@jimtjames feel free to add anything else you see fit