Speed up conversion to dicts/lists

differentmatt / filbert

JavaScript parser of Python

Other

133 stars 27 forks source link

Speed up conversion to dicts/lists #58

Closed nwinter closed 8 years ago

nwinter commented 9 years ago

I could be wrong, but I think conversion to dicts/lists (which has shown to take a decent amount of time in my profiling) could be sped up. All these functions we're defining here could probably be just defined once and then referenced when we convert a new native type, instead of being redefined every time we make a native type.

It's not a huge performance killer compared to other stuff I'm investigating now, but some day we should get it.

nwinter commented 8 years ago

@basicer I wonder if this is related to any Python performance issues we have been seeing in the new interpreter?

basicer commented 8 years ago

You are correct. They were very slow. I already refactored this in the newest version of filbert. =]