search

differentmatt / filbert

JavaScript parser of Python
Other
133 stars 27 forks source link

v1 target refinement? #85

Open robertleeplummerjr opened 7 years ago

robertleeplummerjr commented 7 years ago

@differentmatt ty so much for your hard work on this project! I've been able to review in depth the internals of filbert, and what it accomplishes. I was hoping to open communication between The OpenMined project for assisting with this project so to facilitate growth towards v1. In it's current state, there is much code in place to assist with getting the ast to run in javascript, and while I think that is a fantastic concept, I would like to see what is thought about splitting that behavior into two items:

  1. An ast parser, that just parses ast's as a pseudo javascript reference
  2. An ast translator (or caster) that changes the ast to be compatible with an environment

Thoughts welcome!

basicer commented 7 years ago

Hey @robertleeplummerjr

Checkout skulpty, it has the sort of separation your talking about. It also uses the skulpt parser instead of acorn, so it's a little bit more complete.

https://github.com/codecombat/skulpty

differentmatt commented 7 years ago

Hi @robertleeplummerjr,

I'm open to working with you and @OpenMined on this project, including separating behaviors as you suggest.

You may want to check out the skulpty project @basicer referenced first, since it's probably a stronger base for what you're looking for. At @codecombat we switched from filbert to skulpty about a year ago for our in-browser Python needs.