Deduplicate translation.json using succinct keys

diffix / dashboards

Desktop application for producing anonymized dashboards using `Open Diffix`.

https://www.open-diffix.org

Other

2 stars 0 forks source link

Deduplicate translation.json using succinct keys #11

Open pdobacz opened 2 years ago

pdobacz commented 2 years ago

See https://github.com/diffix/bi_diffix/pull/7#discussion_r981538164

(when done, open a low-priority issue in desktop to do the same, for consistency)

pdobacz commented 2 years ago

I think Edon started a discussion to keep the keys as they are here. The duplication doesn't bother me personally, and I think Edon makes a point there. Do we want to keep this issue?

edongashi commented 2 years ago

I think natural keys have a few benefits:

We don't need to add anything to the json file while developing because of fallback. The fallback is the key, which is the English version of the string.
You can see the final text directly from source code.
It will be easier to review and translate to German because the file will be of shape "English": "German"

cristianberneanu commented 2 years ago

I won't insist on this too much, especially if you are both against the change, but I find the approach pretty impractical.

The text appears in code, which adds noise and messes up the layout, it also appears twice in the English translation file, and once more for each additional language we support. There are a lot of places to update when one changes a displayed string.

At the very least, we should get rid of the English translation file, as it is 100% redundant.

edongashi commented 2 years ago

if you are both against the change

I'm not against changing, I agree that it's very noisy currently. Better to do it now in early stages than later.

pdobacz commented 2 years ago

Oh, maybe I'm confused then. I thought the deduplication here is about not having the natural language keys and always referring to the translation.json for the actual contents.

If so, I'm slightly against changing, but not a strong opinion. Dropping the English translation would be great though

pdobacz commented 2 years ago

Do we have a decision on this one? Any new arguments, after i18n caused problems in the webpage translation?