search

diffix / explorer

Tool to automatically explore and generate stats on data anonymized using Diffix
MIT License
2 stars 1 forks source link

Refactor explorer parameter validation #261

Closed dandanlen closed 4 years ago

dandanlen commented 4 years ago

I don't like that there is so much data and functionality added in the ExplorationRegistry and Registration. This leads to weird things, like that the launch is performed from the Registration, somewhat hidden from the place where I expect it to be, in the ExplorerController.Explore. Or the fact that the request data gets to be used here.

My feeling is that all the data and functionality from the Registration should actually be moved in the Exploration. The ExplorationRegistry should be just a simple dictionary used to convert a Guid to an Exploration.

I think that we should create a separate issue for this, so that we can merge this PR faster.

Originally posted by @AndreiBozantan in https://github.com/diffix/explorer/pull/253

dandanlen commented 4 years ago

This was addressed as part of the multi-column refactoring work. (#308, #316)