diffix / explorer

Tool to automatically explore and generate stats on data anonymized using Diffix
MIT License
2 stars 1 forks source link

More bug squashing #288

Closed dandanlen closed 4 years ago

dandanlen commented 4 years ago

4 commits here:

Fixes #282

sebastian commented 4 years ago

Seems Travis isn't happy. Reran the failing build once to see if that could help, but it didn't rectify it. https://travis-ci.com/github/diffix/explorer/builds/179288451

dandanlen commented 4 years ago

I am not quite sure I follow the change regarding making the system non-lazy in evaluating the stats. Superficially the laziness sounds like it would be an advantage by potentially not executing analyses unless they are needed?

We need to evaluate the results strictly/eagerly from the api consumer's perspective ie. we need to drive the results to completion in the background task, not when the /result api endpoint is hit. In this case the laziness in question only impacted the 'shaping' of the data (and only for some metrics) but I wanted to make everything consistent and evaluate these objects to minimise the response time via /result.

I reran travis this morning and it worked - there were some bad gateway responses yesterday that caused the failing tests.