search

diffix / explorer

Tool to automatically explore and generate stats on data anonymized using Diffix
MIT License
2 stars 1 forks source link

Multi-column queries can fail silently #346

Closed sentry-io[bot] closed 3 years ago

sentry-io[bot] commented 3 years ago

Correlation analysis can continue without valid data since exceptions from the inner queries can in some cases be swallowed - better to throw these and deal with them explicitly.

Sentry Issue: EXPLORER-K4

System.ArgumentNullException: Value cannot be null. (Parameter 'source')
  File "/build/src/explorer/Components/ColumnCorrelationComponent.cs", line 219, in Explore
  File "/build/src/explorer/Components/ExplorerComponent.cs", line 10, in MoveNext
  File "/build/src/explorer/Components/ColumnCorrelationComponent.cs", line 175, in YieldMetrics
  File "/build/src/explorer/Components/CorrelatedSampleGenerator.cs", line 28, in YieldMetrics
  Module "Explorer.Components.CorrelatedSampleGenerator+<YieldMetrics>d__5", in System.Threading.Tasks.Sources.IValueTaskSource<System.Boolean>.GetResult
...
(31 additional frame(s) were not displayed)

Explorer.ExplorerException: Error in MultiColumnExploration for Clinic/patients/title,firstname,lastname,suffix,gender,social_insurance_number,date_of_birth,primary_physician,remarks,active,pharmacy_id,flags,previous_physician,rostered_date,soundex1,soundex2,default_location,preferred_contact_type,detailed_msg_consent,have_regular_dentist,medication_insurance,have_dental_insurance,nkda,created_by_kiosk,marketing_source_id,old_pharmacy_id,audit_created_at,audit_created_by,audit_modified_by,official_language_pref,terminated_date,terminated_reason,status_date,chart_number,spokenlanguage,donotemail,allow_cihi_inclusion,prevent_kiosk_check_in,auditid,terminated_reason_code,blockedinolis,referred_by_provider_id,referred_by_provider_clinic_id,webenabled,portalconsentsigned,portalconsentsignedon.
  File "/build/src/explorer/AbstractExploration.cs", line 70, in MoveNext
  File "/build/src/explorer/AbstractExploration.cs", line 21, in MoveNext
  File "/build/src/explorer/Exploration.cs", line 150, in MoveNext
  File "/build/src/explorer/Exploration.cs", line 182, in RunStage
  File "/build/src/explorer/Exploration.cs", line 154, in MoveNext
...
(11 additional frame(s) were not displayed)

Exception occurred in exploration task.
sebastian commented 3 years ago

Oh, I thought Sentry had come up with this useful issue title and was mightily impressed (but then it was the human intelligence of Daniel instead :))