Fix CI by fixing NativeDeps swt version and removing CategoryPublisherTest.java

diffplug / goomph

IDE as build artifact

Apache License 2.0

130 stars 30 forks source link

Fix CI by fixing NativeDeps swt version and removing CategoryPublisherTest.java #169

Closed jmini closed 2 years ago

jmini commented 2 years ago

Fixes #168

jmini commented 2 years ago

No need to publish a new version of the library after this merge.

jmini commented 2 years ago

I do not see CI build results…

jmini commented 2 years ago

I found some CI results here: https://app.circleci.com/pipelines/github/jmini/goomph/8/workflows/f7a2e027-72f1-4e9b-b002-f3fbe58300ec/jobs/18

It is not that simple:

Now the Java 11 build is failing with:

Caused by: java.lang.Error: p2asmaven requires JRE 8, this is JRE 11
    at com.diffplug.gradle.eclipserunner.EquinoxLauncher.<init>(EquinoxLauncher.java:69)
    ... 6 more

What should I do?

nedtwigg commented 2 years ago

I completely bastardized your PR, but CI now works on Java 8 and Java 11, which I think was your core issue. Let me know if I missed the point.

jmini commented 2 years ago

This is exactly what I needed.

Thank you a lot for this.