search

diffplug / goomph

IDE as build artifact
Apache License 2.0
130 stars 30 forks source link

Clearly mark the abandoned parts of the project in the README. #192

Closed nedtwigg closed 1 year ago

nedtwigg commented 2 years ago

This plugin is still actively maintained, but there are a few abandoned aspects. They still work for some people, but are broken for most. We're happy to take PRs for them, but it would be polite if we clearly marked which parts are abandoned.

restlessronin commented 2 years ago

@nedtwigg since it appears that many of the plugins are not working for new users, perhaps it would be best to start the readme with the parts that are still working? UPDATE. I notice you've already done this.

AFAIK, the mavencentral plugin is workiing, but I find I'm using the generated BOM via https://github.com/jmini/ecentral rather than using the plugin directly. I'm not sure about the status of the remaining plugins since I haven't managed to get any samples working.

For background, I'm trying to convert an old RCP app (still working on the latest Eclipse PDE) to a gradle build that can be consumed by other IDE's (IDEA and VS Code). All of the individual subprojects can be built using vanilla gradle for the most part (no plugins needed beyond the usual 'java', 'java-library', etc.). The external dependencies already have OSGI manifests, and the project also has complete manifests, so there's no need for bndtools.

I just need one more subproject that packages everything together and uses the equinox launcher to start the app. My approach has been to replicate the relevant 'Eclipse Application Launch Configuration' command line within gradle. Thanks to MavenCentral (via ECentral), the dependency resolution can be performed by gradle. The only remaining part is to create the JavaExec, which sets the various osgi properties that go into config.ini.

I've already started putting this together, but I assume that most of this is already somewhere in your package. I'd be happy to work with what you have instead of re-inventing the wheel, if there's a minimal set of files that need changing. If you can point me at the relevant files, I can take a crack at updating them if needed.

UPDATE. I just saw the modified README. You may have already answered the question there.

2nd UPDATE. I noticed that equinoxLaunch is not abandoned, which sounds like exactly what I'm looking for. However, I'm having problems getting this to work. I've created a new issue, and added to an existing one.

restlessronin commented 2 years ago

This is an unrelated issue, but the javadoc URL's are broken. I get an error page with the message 'Internal server error. I will take a look and hopefully fix the issue asap'. Not a biggie, since I can look at the source file directly.

Example. https://javadoc.io/doc/com.diffplug.gradle/goomph/3.37.0/com/diffplug/gradle/eclipserunner/EquinoxLaunchPlugin.html

nedtwigg commented 2 years ago

I think most of the "abandoned" is broken only because of recent Java versions. I think all of it worked in Java 11. A few PRs can "unabandon" it. I'm gonna wait to merge this change to README to see if the ucp fix etc. bring these parts back to life.