search

diffplug / goomph

IDE as build artifact
Apache License 2.0
130 stars 30 forks source link

possibility to set the repository name for the 'FeaturesAndBundlesPublisher' #212

Open wszeboreq opened 1 year ago

wszeboreq commented 1 year ago

It seems 'FeaturesAndBundlesPublisher' is missing a possibility to set the created repository name ('<repository name=...' in the generated 'artifacts.xml' and 'content.xml'). Repository names generated by default contain the repository disk path (i.e. one from the build server) which may be unacceptable.

I believe this may be done via 'repositoryName'/'metadataRepositoryName'/'artifactRepositoryName' attributes of the 'p2.publish.featuresAndBundles' Ant task (see https://wiki.eclipse.org/Equinox/p2/Publisher). Maybe (not sure) also somehow via 'p2.metadata.repo.name'/'p2.artifact.repo.name' properties.

Some general way of specifying some Ant task attribute would also be beneficial.

Is there any workaround way to specify the repository name for 'FeaturesAndBundlesPublisher' in the current Goomph version?

nedtwigg commented 1 year ago

Happy to merge a PR for this, but we're not using this feature anymore at DiffPlug.