search

diffplug / goomph

IDE as build artifact
Apache License 2.0
130 stars 30 forks source link

Open BndManifestPlugin for any Jar task #78

Closed hacki11 closed 4 years ago

hacki11 commented 6 years ago

My use case is to create shadowed bundles using johnrengelman ShadowJar plugin and having a bundle conform MANIFEST.MF inside.

BndManifestPlugin uses the Jar task and can not be used with the ShadowJar (extends Jar) task. https://github.com/diffplug/goomph/blob/1dec03baa2d930cf46f3eb70062a07260abe42d4/src/main/java/com/diffplug/gradle/osgi/BndManifestPlugin.java#L100

Would be nice if we could open up the api to provide a JarTask with BndManifestExtension. What do you think? Are you open for a pr?

nedtwigg commented 6 years ago

Sounds great, definitely open for a PR!

hacki11 commented 4 years ago

done: https://github.com/diffplug/goomph/pull/79