search

diffplug / gradle-and-eclipse-rcp

Gradle and Eclipse RCP
Apache License 2.0
45 stars 9 forks source link

Will this support latest JDK 17 #19

Closed zeefahs13 closed 3 years ago

zeefahs13 commented 3 years ago

Is the gradle used in this project upgraded in accordance with new JDK 17 ? Is there us any plan? Eclipse will no longer supports PDE Will this work even after it?

nedtwigg commented 3 years ago

Happy to take a PR for it. Goomph definitely works with JDK 17, but we are not proactively updating this demo project anymore.

zeefahs13 commented 3 years ago

Happy to take a PR for it. Goomph definitely works with JDK 17, but we are not proactively updating this demo project anymore.

@nedtwigg I have seen your code which is supporting until eclipse version 4.5.2 and any version above goomph is throwing error. Can we incorporate Eclipse 4.20 as well?

zeefahs13 commented 3 years ago

Happy to take a PR for it. Goomph definitely works with JDK 17, but we are not proactively updating this demo project anymore.

@nedtwigg I have seen your code which is supporting until eclipse version 4.5.2 and any version above goomph is throwing error. Can we incorporate Eclipse 4.20 as well?

@nedtwigg how about the gradle version, you are using 6+ which will not work with JDK 17. Do you have any plan stored in for latest release of JDK 17 for September 14 2021?

nedtwigg commented 3 years ago

https://github.com/diffplug/goomph/issues/35#issuecomment-883550242

zeefahs13 commented 3 years ago

diffplug/goomph#35 (comment)

Sorry I did not get you could you please elaborate