Step 'ktlint' found problem in 'build.gradle.kts':
Error on line: 64, column: 1
rule: trailing-comma-on-call-site
Missing trailing comma before ")"
It seems it is only applying the line length change without the trailing comma change. The error message is highly confusing too, because there is no expectation for a trailing comma in the original one-line code, only in the intermediate reformatted version.
If manually reformatting, then it passes. Had no idea where the error is, I guess the line number is also wrong, referring to the intermediate reformatted version and not the original?
Your Environment
Version of ktlint used:
Default in gradle-spotless-plugin
Relevant parts of the .editorconfig settings
max_line_length = 100
Name and version (or code for custom task) of integration used (Gradle plugin, Maven plugin, command line, custom Gradle task):
gradle-spotless-plugin: 6.18.0
I originally filed this to ktlint at https://github.com/pinterest/ktlint/issues/1979 but it seems like it's likely a spotless issue. So copying in from there.
Expected Behavior
Code formats
Observed Behavior
Failure with
trailing-comma-on-call-site
Steps to Reproduce
If this line is too long based on editorconfig values, then it is supposed to reformat to split lines and have a trailing comma
However, instead it gives an error
It seems it is only applying the line length change without the trailing comma change. The error message is highly confusing too, because there is no expectation for a trailing comma in the original one-line code, only in the intermediate reformatted version.
We can see it in https://github.com/curioswitch/protobuf-jackson/pull/14, running
spotlessApply
in this repo with the change will still fail with that error message instead of reformatting.If manually reformatting, then it passes. Had no idea where the error is, I guess the line number is also wrong, referring to the intermediate reformatted version and not the original?
Your Environment
.editorconfig
settingsmax_line_length = 100