diffpy / diffpy.fourigui

Other
0 stars 7 forks source link

Ready for v0.1.1 PyPI/GitHub release #31

Closed cadenmyers13 closed 2 weeks ago

cadenmyers13 commented 1 month ago

Release checklist for GitHub contributors

Please mention @sbillinge when you are ready for release. Include any additional comments necessary, such as version information and details about the pre-release.

sbillinge commented 1 month ago

Thanks @cadenmyers13 please ping me again when all the items are completed.

cadenmyers13 commented 1 month ago

@bobleesj Following the README, when I install with conda install diffpy.fourigui I get the installation error that diffpy.fourigui is not available on conda-forge. However, it install with pip install diffpy.fourigui. Is this because this package isn't on conda-forge?

bobleesj commented 1 month ago

@cadenmyers13 for conda-forge, yes. We currently have it under the rcpre-release channel.

sbillinge commented 1 month ago

@cadenmyers13 I changed this to 0.1.1 in the title. This is the checklist for the next release so we want to bump the number. We will do a pre-release (so there wil be an rc0) but it will be 0.1.1rc0 but I don't think we need a separate checklist for the rc's

sbillinge commented 1 month ago

@cadenmyers13 I added issues that we want to close on this release to the 0.1.1 release milestone.

bobleesj commented 1 month ago

@sbillinge

Could you please setup codecov token for diffpy.fourigui? Appears diffpy.fourigui has not been configured as expected: https://app.codecov.io/gh/diffpy

Screenshot 2024-10-23 at 8 12 52 PM
sbillinge commented 1 month ago

OK, not sure how to do this. I thought I configured it correctly and added the CODECOV_TOKEN to the repo, but for some reason the upload to codecov step is being skipped in the CI workflow, and no coverage is uploaded.

bobleesj commented 1 month ago

@cadenmyers13 Just to note the codecov badge works. Thanks @sbillinge!

cadenmyers13 commented 1 month ago

@sbillinge Can I get a verification that the licensing is correct for this package?

sbillinge commented 1 month ago

@sbillinge Can I get a verification that the licensing is correct for this package?

yes, can confirm. I checked that on the list.

cadenmyers13 commented 2 weeks ago

@sbillinge @bobleesj Once the opened PRs are confirmed and merged we should be good to release

sbillinge commented 2 weeks ago

@sbillinge @bobleesj Once the opened PRs are confirmed and merged we should be good to release

in other words, we are not ready for release. Please let me know when we are.....

cadenmyers13 commented 2 weeks ago

All issues and PRs associated with package content have been closed and content is up to date with current cookiecutter standard. New issue (#65) has been created for support of python 3.13.

bobleesj commented 2 weeks ago

@cadenmyers13 Please provide a bit more context on why this issue is closed while we have a checklist for 0.2.0 being created. https://github.com/diffpy/diffpy.fourigui/issues/65#issuecomment-2468566818

I recall 0.1.1 was simply for recutting and 0.2.0 would be recutting + supporting py 3.13

cadenmyers13 commented 2 weeks ago

@cadenmyers13 Please provide a bit more context on why this issue is closed while we have a checklist for 0.2.0 being created. #65 (comment)

I recall 0.1.1 was simply for recutting and 0.2.0 would be recutting + supporting py 3.13

comment has been updated^

sbillinge commented 2 weeks ago

Closed as completed.