diffpy / diffpy.github.io

web hosting for www.diffpy.org
2 stars 12 forks source link

Link to [vincefn.net](vincefn.net) not `https` secure #32

Open connorjbracy opened 2 years ago

connorjbracy commented 2 years ago

In products/diffpycmi/contents: line 71, there is a link to "https://vincefn.net/ObjCryst/" which specifies the HTTPS protocol should be used but apparently this host does not support HTTPS. The linkcheck fails as the HTTPS request cannot be satisfied, but the link can still be reached by using the protocol agnostic link vincefn.net/ObjCryst/, although users may get a warning about accessing an insecure website. Ultimately, I think providing the link with or without the inclusion of the https:// portion will still properly direct users to the intended website, but including the https:// portion causes our linkcheck validation of the documentation update to fail.

@sbillinge, let me know if it is okay to change the reference link to this "insecure" format or what else should be done instead.

sbillinge commented 2 years ago

yes, ok.

On Tue, Dec 7, 2021 at 11:32 AM Connor J. Bracy @.***> wrote:

In products/diffpycmi/contents: line 71, there is a link to " https://vincefn.net/ObjCryst/" which specifies the HTTPS protocol should be used but apparently this host does not support HTTPS. The linkcheck fails as the HTTPS request cannot be satisfied, but the link can still be reached by using the protocol agnostic link vincefn.net/ObjCryst/, although users may get a warning about accessing an insecure website. Ultimately, I think providing the link with or without the inclusion of the https:// portion will still properly direct users to the intended website, but including the https:// portion causes our linkcheck validation of the documentation update to fail.

@sbillinge https://github.com/sbillinge, let me know if it is okay to change the reference link to this "insecure" format or what else should be done instead.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/diffpy/diffpy.github.io/issues/32, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUMNAS22HUIQTPUOFTLUPYZLDANCNFSM5JRWA2CQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

-- Simon Billinge Professor, Columbia University Physicist, Brookhaven National Laboratory