search

diffpy / diffpy.github.io

web hosting for www.diffpy.org
2 stars 12 forks source link

Master #36

Closed connorjbracy closed 2 years ago

connorjbracy commented 2 years ago

@sbillinge, BEFORE MERGING, READ BELOW

Note This PR should contain the changes to the static files of diffpy.org necessary to update the site to what it should be for hosting pdfgetx v2.1.1, but it is not reflecting those changes within my fork's GitHub pages site. Do with this information what you will, I'll look into it more when I'm done travelling...

Duplication of Slack message I'm thinking it might be some weirdness to do with the fork being of a GitHub pages repo, but I'm not really sure. My flight is about to start boarding but I figured I'd give you a sitrep so you know where things stand. I'll also open a PR for the changes that should update the website in case you have a way to preview them or want to test if merging them would update the site (with accepting that undoing the commit may be necessary, if needed, but also the non-update I'm observing seems to leave the website entirely as it currently is so maybe a revert won't be needed even if the changes are ineffective).

connorjbracy commented 2 years ago

@sbillinge, BEFORE MERGING, READ BELOW

Note This PR should contain the changes to the static files of diffpy.org necessary to update the site to what it should be for hosting pdfgetx v2.1.1, but it is not reflecting those changes within my fork's GitHub pages site. Do with this information what you will, I'll look into it more when I'm done travelling...

Duplication of Slack message I'm thinking it might be some weirdness to do with the fork being of a GitHub pages repo, but I'm not really sure. My flight is about to start boarding but I figured I'd give you a sitrep so you know where things stand. I'll also open a PR for the changes that should update the website in case you have a way to preview them or want to test if merging them would update the site (with accepting that undoing the commit may be necessary, if needed, but also the non-update I'm observing seems to leave the website entirely as it currently is so maybe a revert won't be needed even if the changes are ineffective).

@sbillinge, the diff is even less human-readable in raw form than I hoped. It's probably best to hold off on touching this until I can work again :(

sbillinge commented 2 years ago

closing because diffpy.org is broken and I want to see if it is related to this PR (even though it is not merged)