diffpy / diffpy.labpdfproc

apps for preprocessing laboratory x-ray data before sending to pdfgetx3
Other
1 stars 10 forks source link

Remove gooey in conda.txt and install gooey via pip in CI, setup macOS CI to prevent building wxPython #137

Open bobleesj opened 3 days ago

github-actions[bot] commented 3 days ago

Warning! No news item is found for this PR. If this is a user-facing change/feature/fix, please add a news item by copying the format from news/TEMPLATE.rst.

bobleesj commented 3 days ago

(Not ready for review)

codecov[bot] commented 3 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 99.31%. Comparing base (a2572da) to head (f6ac225).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #137 +/- ## ======================================= Coverage 99.31% 99.31% ======================================= Files 6 6 Lines 293 293 ======================================= Hits 291 291 Misses 2 2 ```
bobleesj commented 3 days ago

@sbillinge ready for review. pls see in-line comments. Thank you.

bobleesj commented 3 days ago

@yucongalicechen tagging Yucong as well to share what's going on here.

bobleesj commented 2 days ago

Does adding wxpython to conda.txt allow you to set it back to Linux-latest?

I checked wxpython's conda-forge files, no support for py313 as of now:

Screenshot 2024-11-28 at 8 44 26 AM

So it will most likely break the CI while installing it.

Ref: https://anaconda.org/conda-forge/wxpython/files