search

diffpy / diffpy.labpdfproc

apps for preprocessing laboratory x-ray data before sending to pdfgetx3
Other
1 stars 10 forks source link

Precommit instructions in README #67

Closed cadenmyers13 closed 6 months ago

sbillinge commented 6 months ago

@cadenmyers13 I was able to merge your PR on pdfmorph, so that is good. Here I suggest we close this PR and make a new one for the pre-commit things (I don't remember what you had to do there beyond what i already did, maybe nothing? In that case no need to make a PR for that). then another PR for the file-path changes. Thanks so much.

cadenmyers13 commented 6 months ago

@sbillinge I think just the formatting on the README needs to be fixed. its not showing codeblocks. Ill take care of that and create a PR

sbillinge commented 6 months ago

@sbillinge I think just the formatting on the README needs to be fixed. its not showing codeblocks. Ill take care of that and create a PR

we may not need code blocks everywhere there, use your judgement. To put code snippets inline just use back-quotes (see here for a deeper discussion: https://stackoverflow.com/questions/10870719/inline-code-highlighting-in-restructuredtext

cadenmyers13 commented 6 months ago

@sbillinge I think just the formatting on the README needs to be fixed. its not showing codeblocks. Ill take care of that and create a PR

we may not need code blocks everywhere there, use your judgement. To put code snippets inline just use back-quotes (see here for a deeper discussion: https://stackoverflow.com/questions/10870719/inline-code-highlighting-in-restructuredtext

Yeah code snippets, not code blocks. That is what i mean 😆