search

diffpy / diffpy.pdfgui

graphical user interface for real space structure refinement to PDF
Other
20 stars 29 forks source link

Files in doc directory #157

Closed cadenmyers13 closed 2 months ago

cadenmyers13 commented 2 months ago

@sbillinge Discussed a bit with Andrew on where we should put things and this is what I've got right now.

sbillinge commented 2 months ago

this looks about right. Please make a PR with any changes that allow you to build the docs locally, and on a separate PR a workflow with the doc builds in a GitHub action, and we can work to make that pass too.

cadenmyers13 commented 2 months ago

this looks about right. Please make a PR with any changes that allow you to build the docs locally, and on a separate PR a workflow with the doc builds in a GitHub action, and we can work to make that pass too.

docs.yml is already added, no?

sbillinge commented 2 months ago

this looks about right. Please make a PR with any changes that allow you to build the docs locally, and on a separate PR a workflow with the doc builds in a GitHub action, and we can work to make that pass too.

docs.yml is already added, no?

Ah, ok. Let me know when you are confident the docs are building locally and I can merge and it will test the docs build then

cadenmyers13 commented 2 months ago

this looks about right. Please make a PR with any changes that allow you to build the docs locally, and on a separate PR a workflow with the doc builds in a GitHub action, and we can work to make that pass too.

docs.yml is already added, no?

Ah, ok. Let me know when you are confident the docs are building locally and I can merge and it will test the docs build then

The htmls build when i run make html in doc. However im getting this error: Screenshot 2024-08-08 at 4 12 13 PM

sbillinge commented 2 months ago

I merged this so we will need the fixes for this on a new PR. Thanks.