search

diffpy / diffpy.pdfgui

graphical user interface for real space structure refinement to PDF
Other
19 stars 27 forks source link

check whether `asunicode(s)` is actually needed #188

Open sbillinge opened 3 weeks ago

sbillinge commented 3 weeks ago

when dropping py2 support, do we still even need asunicode()? Check where it is used and whether it can be removed.

Tieqiong commented 2 weeks ago

@sbillinge this method is used for load and save binary files (mainly zipped project file). I think we can remove it and simply use .decode("utf-8").

Yes test would be the right thing to do