search

diffpy / diffpy.pdfgui

graphical user interface for real space structure refinement to PDF
Other
18 stars 27 forks source link

fix open project ddp file on mac OS #22

Closed dragonyanglong closed 7 years ago

dragonyanglong commented 7 years ago

Hi Pavol,

I change the matchstring. Now in Mac OS, when open project files, people can only choose .ddp files.

codecov[bot] commented 7 years ago

Codecov Report

Merging #22 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   25.69%   25.69%           
=======================================
  Files          90       90           
  Lines       11914    11914           
=======================================
  Hits         3061     3061           
  Misses       8853     8853
Impacted Files Coverage Δ
src/diffpy/pdfgui/gui/mainframe.py 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea7837d...eeae97e. Read the comment docs.

pavoljuhas commented 7 years ago

@dragonyanglong - a couple of small points - please, adjust your git setup to use your full name in commits. The commit message could be more descriptive as it does not say what was fixed; also the change applies to all operating systems. See the merge commit message in 4b82a8feec0db01e8d87f6e909c1a734eb0e3fcf. Otherwise good job, thank you!