search

diffpy / diffpy.pdfgui

graphical user interface for real space structure refinement to PDF
Other
18 stars 27 forks source link

Fix copy paste bytes for wxpython #50

Closed dragonyanglong closed 3 years ago

dragonyanglong commented 3 years ago

This PR is for fixing the copy-paste fit tree item bug. Since py3 bytes cannot combine with str together as in py2, thus using base64 to convert bytes to str first then follow the old strategy for copy-paste function.

codecov[bot] commented 3 years ago

Codecov Report

Merging #50 (a00ff15) into next (a9de126) will decrease coverage by 0.00%. The diff coverage is 10.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next      #50      +/-   ##
==========================================
- Coverage   57.56%   57.56%   -0.01%     
==========================================
  Files          95       95              
  Lines       10985    10988       +3     
==========================================
+ Hits         6324     6325       +1     
- Misses       4661     4663       +2
Impacted Files Coverage Δ
src/diffpy/pdfgui/gui/fittree.py 45.31% <10.00%> (-0.08%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a9de126...a00ff15. Read the comment docs.

dragonyanglong commented 3 years ago

@sbillinge @pavoljuhas . Please review and merge.