search

diffpy / diffpy.pdfgui

graphical user interface for real space structure refinement to PDF
Other
19 stars 27 forks source link

REV: revert pickle protocol back to the highest one. #70

Closed dragonyanglong closed 2 years ago

dragonyanglong commented 2 years ago

This reverts the commit a0c745e48b86eda144212e977372dd4673fae4d3 work. The pickle will be saved in the highest protocol available in the python3 version.

dragonyanglong commented 2 years ago

@sbillinge Please review and merge. For saving a project file, I agree with you that we should move the protocol to most updated one. For loading a project file, personally I think we can still keep the compatibility, as Pavol did before in the old version, that when raising the loading error, try the protocol=0 (lowest one) again to load the project file.

For recommending people switch from py2 to py3, personally I think once people have their conda environment as py3, as most people did nowadays, install py3 version looks like more straightforward.