diffpy / diffpy.snmf

Other
1 stars 6 forks source link

Test the package with example data #128

Open bobleesj opened 2 weeks ago

bobleesj commented 2 weeks ago

Problem

The current package does not provide example data while the main app below requires input_directory

def main():
    args = create_parser()
    if args.input_directory is None:
        args.input_directory = Path.cwd()
    grid, input_data = load_input_signals(args.input_directory)

Proposed solution

We can attempt to use test data nmf_mapping from https://github.com/diffpy/diffpy.nmf_mapping/blob/main/diffpy/nmf_mapping/tests/data and see whether the code works.

bobleesj commented 2 weeks ago

Noticed that data are provided under examples/mix___ZnSe-w_0.4___BaTiO3_c-w_0.6 Have you tried running the package with these data? @Fil158

sbillinge commented 2 weeks ago

if the data are small, we can add it to the repo to make it easy for users.

Fil158 commented 6 days ago

image

This error occurs when I try with those data

bobleesj commented 6 days ago

Yes, I had reproduced the error before. It is because the code wasn't tested using real files/data.

As of now, our current priority is to implement/interpret the snmf algo

sbillinge commented 6 days ago

Also, I suggest when we work on this issue, let's change the filename of the example data to something more readable and easy to type......