search

diffpy / diffpy.srmise

Other
0 stars 7 forks source link

Make example run successfully on DataClusters #75

Closed stevenhua0320 closed 2 months ago

sbillinge commented 2 months ago

This has conflicts

stevenhua0320 commented 2 months ago

Hi Simon, I think it might be more appropriate to move the comment here: Could you revert PR #73 right now? Since Luke said in the comment that this commit might cause breaking changes, I'm not sure right now if this would affect other files that depend on DataClusters class. For this PR it is just change the syntax from py2 to py3, so this is a safe refactor, and right now we should use this version in case there is uninteded error that uses DataCluster class.

stevenhua0320 commented 2 months ago

Hi Simon, now it is a safe merge because the conflicts are created by merging PR #73. This is a safe merge because it only changes next() function defined in py2 to __next__ defined in py3 and made changes from numpy int object to int to make correct index slicing. I have tested on my local and it could safely print the example.