search

diffpy / libdiffpy

DiffPy C++ library for calculation of PDF and other real-space quantities
Other
7 stars 13 forks source link

PeakWidthModel serialization #22

Closed pavoljuhas closed 5 years ago

pavoljuhas commented 5 years ago

Convert PWM and derived classes to use explicit serialization. Avoid restricting what internal data can be in derived classes.

codecov[bot] commented 5 years ago

Codecov Report

Merging #22 into master will increase coverage by 0.25%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #22      +/-   ##
=========================================
+ Coverage   87.04%   87.3%   +0.25%     
=========================================
  Files         135     136       +1     
  Lines        7274    7326      +52     
  Branches      535     533       -2     
=========================================
+ Hits         6332    6396      +64     
+ Misses        736     726      -10     
+ Partials      206     204       -2
Impacted Files Coverage Δ
src/diffpy/srreal/ConstantRadiiTable.cpp 87.5% <ø> (ø) :arrow_up:
src/diffpy/srreal/DebyeWallerPeakWidth.cpp 100% <100%> (+16.66%) :arrow_up:
src/diffpy/srreal/PeakWidthModel.hpp 100% <100%> (+12%) :arrow_up:
src/diffpy/srreal/DebyeWallerPeakWidth.hpp 100% <100%> (ø) :arrow_up:
src/diffpy/srreal/ConstantPeakWidth.hpp 100% <100%> (ø) :arrow_up:
src/diffpy/srreal/JeongPeakWidth.cpp 100% <100%> (ø) :arrow_up:
src/diffpy/srreal/JeongPeakWidth.hpp 100% <100%> (ø) :arrow_up:
src/diffpy/srreal/PeakWidthModel.cpp 93.33% <100%> (ø) :arrow_up:
src/tests/TestPeakWidthModel.hpp 100% <100%> (ø)
src/diffpy/srreal/ConstantPeakWidth.cpp 82.6% <100%> (+0.79%) :arrow_up:
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b9efe6f...3326198. Read the comment docs.