Open st3107 opened 2 years ago
Sometime wrong with the build process. Need to change the scon file. This should be in another PR.
should I wait to review?
On Tue, Oct 26, 2021 at 3:15 PM Songsheng Tao @.***> wrote:
Sometime wrong with the build process. Need to change the scon file. This should be in another PR.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/diffpy/libdiffpy/pull/31#issuecomment-952235136, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWULIPQ5RHUPURXXK66DUI344HANCNFSM5GYN4S5Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-- Simon Billinge Professor, Columbia University Physicist, Brookhaven National Laboratory
Yes. This is not a simple issue. It is related to the scon build. I need some time to figure it out.
On Tue, Oct 26, 2021 at 3:40 PM Simon Billinge @.***> wrote:
should I wait to review?
On Tue, Oct 26, 2021 at 3:15 PM Songsheng Tao @.***> wrote:
Sometime wrong with the build process. Need to change the scon file. This should be in another PR.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/diffpy/libdiffpy/pull/31#issuecomment-952235136, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABAOWULIPQ5RHUPURXXK66DUI344HANCNFSM5GYN4S5Q
. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
-- Simon Billinge Professor, Columbia University Physicist, Brookhaven National Laboratory
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/diffpy/libdiffpy/pull/31#issuecomment-952258800, or unsubscribe https://github.com/notifications/unsubscribe-auth/AI27ND4HANXNZLYL2HGFREDUI37ZNANCNFSM5GYN4S5Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
-- [image: photo] Songsheng Tao Ph. D. student, Columbia University
347-749-7947 Create your own email signature https://www.wisestamp.com/create-own-signature/?utm_source=promotion&utm_medium=signature&utm_campaign=create_your_own&srcid=
@sbillinge I added the warning message. Refer to the this issue.