improve scons behavior when test_installed is set

diffpy / libdiffpy

DiffPy C++ library for calculation of PDF and other real-space quantities

Other

7 stars 13 forks source link

improve scons behavior when test_installed is set #9

Closed pavoljuhas closed 7 years ago

pavoljuhas commented 7 years ago

The test_installed flag tells scons to build unit tests with/respect to the libdiffpy installation in prefix.

[x] allow that flag only for test or alltests command-line targets. Die if there are any other targets or if there are no targets at all.
[x] ~~prepend~~ includedir and libdir ~~before executing SConscript.configure.~~ Do not prepend our own build directory when test_installed is set.

pavoljuhas commented 7 years ago

allow that flag only for test or alltests command-line targets. Die if there are any other targets or if there are no targets at all.

Done. When test_installed flag is set only the test-related targets are defined. Passing any other target on scons command-line will result in failed build.

pavoljuhas commented 7 years ago

prepend includedir and libdir before executing SConscript.configure

Won't do. includeddir and libdir refer only to the installed libdiffpy library. Compiler paths for configured libraries need to be set by other means, e.g., by setting CPATH or LIBRARY_PATH.

... Passing any other target on scons command-line will result in failed build.

Done.