diffpy / sampledb

A DB for sample and synthesis metadata information
http://www.diffpy.org/sampledb/
Other
0 stars 2 forks source link

Print statement when trying to download empty spreadsheet and make sure sockets are closed #41

Closed justcalamari closed 6 years ago

justcalamari commented 6 years ago

Solves #31, #32 and #34.

codecov[bot] commented 6 years ago

Codecov Report

Merging #41 into master will increase coverage by 0.9%. The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #41     +/-   ##
=========================================
+ Coverage   92.46%   93.36%   +0.9%     
=========================================
  Files           9        8      -1     
  Lines         199      196      -3     
=========================================
- Hits          184      183      -1     
+ Misses         15       13      -2
Impacted Files Coverage Δ
sampledb/searchresult.py 93.87% <100%> (+1.37%) :arrow_up:
sampledb/__init__.py 100% <100%> (ø) :arrow_up:
sampledb/tests/test_searchresult.py 92.85% <66.66%> (-7.15%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a5f42aa...734b418. Read the comment docs.

justcalamari commented 6 years ago

I believe this solves #35 now:

with SampleDatabase(host, db, collection, key, user, port) as sdb:
    sdb.publish('1520224107.xlsx')
CJ-Wright commented 6 years ago

Perfect!