diffusionkinetics / open

DiffusionKinetics open-source monorepo
MIT License
115 stars 24 forks source link

Consider moving Plotlyhs to a submodule or individual repo #124

Closed JonathanReeve closed 1 year ago

JonathanReeve commented 3 years ago

I know there are a few advantages to monorepos, but there are a few sticking points, as well. For instance, I wanted to contribute to PlotlyHS, which had its own repo originally, but I'm not really interested in all the other repos in this collection. So I've made my own fork which is only plotlyhs, so that way I can use it in my other software without having to import a ton of unnecessary packages.

There's also the fact that, if I wanted to point Stack or Nix to a GitHub repo containing a custom version of some package, this would be much more difficult when they're all hidden in one giant repo.

I'd suggest moving Plotlyhs, at least, to its own repo. That way, I and other contributors could hack around on it, import it in our own projects, and contribute back to it, without having to worry about all the other libraries in this monorepo. This would be better for you, since you'd get more contributions, but also for the rest of us, since they'd be easier to work with.

glutamate commented 3 years ago

I am no longer developing this repository, Saltcorn is now my main open source project in addition to my day job.

Feel free to take anything from here and put into separate repositories. The DataHaskell crowd has already done this for the datasets package. I think plotlyhs and datasets were the only two projects in this repository that found community traction.

Let me know if I need to do anything to help you take over this package on hackage, I'm also happy to push notices to this repository pointing users to new repositories.

JonathanReeve commented 3 years ago

Sounds great. I'll get in contact with the DataHaskell people about sharing the maintainence, but in the meantime I'd be happy to take it over myself. I've just created a Hackage account with the username JonathanReeve. (Same as my GitHub username.) If you'd want to transfer the ownership/maintainership to me, and post notes in the readmes here, and in its original spot, that would get the ball rolling.

JonathanReeve commented 3 years ago

@glutamate, I'm all set to take over this package, if you want. I think I just need to be added as a maintainer in Hackage. My username is JonathanReeve.

glutamate commented 3 years ago

@JonathanReeve I think that should be done now, on hackage

dschrempf commented 1 year ago

Hi! May I ask about the status of this move? I could not find any new repository, nor does Jonathan appear to be a maintainer on Hackage. Thank you!

JonathanReeve commented 1 year ago

A couple years later than I should've, but I finally figured out all the Hackage stuff necessary, and changed the maintainer information, as well as published a new version with some of my latest changes. Check it out here! Closing this issue as completed.

dschrempf commented 1 year ago

This is great, thank you!