search

digama0 / mmj2

mmj2 GUI Proof Assistant for the Metamath project
GNU General Public License v2.0
72 stars 25 forks source link

Remove checkVersion, to fix #36 #43

Closed cwitty closed 4 years ago

cwitty commented 4 years ago

As described in #36, the code in BatchMMJ2.checkVersion to parse the Java version no longer works with recent Debian Java (version "14-ea"). Since the version it's checking for is ancient, this patch just removes the function (and the call to it) entirely.

On my machine, this does get past the version check and allow me to bring up the mmj2 window.

(Note that I did not check in mmj2.jar; I assumed that would just make the pull request harder to review. If you'd prefer, I could check in mmj2.jar and update the pull request.)

cwitty commented 4 years ago

Oops; I just noticed the "Fixup" pull request from @david-a-wheeler that also disables this check (in a way that will conflict with this patch). Probably it's better to apply his patch than mine, so this pull request should be rejected. (Not sure what the etiquette is here... should I close my own pull request?)

digama0 commented 4 years ago

Sure, I'll use his version.