digama0 / mmj2

mmj2 GUI Proof Assistant for the Metamath project
GNU General Public License v2.0
72 stars 25 forks source link

Compile warnings #51

Closed billh0420 closed 3 years ago

billh0420 commented 3 years ago

I am using the Eclipse IDE. There are many warnings "The serializable class does not declare a static final serialVersionUID field of type long". One suggested way to remove the warning is to add "@SuppressWarnings("serial")". I am willing to make these changes and submit a pull request from my fork. Is this worthwhile doing? Will it be accepted? Thanks.

digama0 commented 3 years ago

I believe you can suppress this warning in eclipse altogether. We don't do any serialization so adding this annotation on every class sounds like pure noise.