search

digama0 / mmj2

mmj2 GUI Proof Assistant for the Metamath project
GNU General Public License v2.0
72 stars 24 forks source link

Eclipse IDE code style formatter: how to disable ? #54

Closed billh0420 closed 3 years ago

billh0420 commented 3 years ago

I couldn't find a way to disable Eclipse IDE code style formatter. Can it be done and, if so, how?

digama0 commented 3 years ago

https://superuser.com/questions/309955/disable-formatting-in-eclipse

digama0 commented 3 years ago

This is not an mmj2 issue. Please refrain from using the issue tracker for things other than bug reports and pull requests.

billh0420 commented 3 years ago

I understand that it is not directly a mmj2 issue. But my intent is not to report bugs but to fix bugs.

But I cannot fix bugs and do a pull request if my updates cause unwanted changes caused by reformatting caused by code style requirements. You said in reply to another request that I had that I should turn off code style formatting. I am fine with that. I did research on it and I found things like the link https://superuser.com/questions/309955/disable-formatting-in-eclipse https://superuser.com/questions/309955/disable-formatting-in-eclipse that you posted. But, doing that change for “Save actions” didn’t work for me. I may not have done it correctly. I will look further into it.

On Jan 8, 2021, at 10:36 PM, Mario Carneiro notifications@github.com wrote:

This is not an mmj2 issue. Please refrain from using the issue tracker for things other than bug reports and pull requests.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/digama0/mmj2/issues/54#issuecomment-757094534, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOSKAR6RADYEGEUZ3RKU443SY7MLBANCNFSM4V3IXF6Q.

digama0 commented 3 years ago

Just make your changes, then when you are preparing the PR, manually edit the diff to undo any superfluous changes. This is good practice for PRs on any project, not just this one. Unless the PR is directly about formatting changes, it should not change any lines except the ones that are involved in the bugfix, and the means by which such a PR is prepared is not my concern. I am still not sure what you actually want to fix with mmj2, and this project is currently in low-power mode so all the minor changes are not very interesting to me.