Move to next LTS version: Java SE 17?

[mountain]

Java SE 11 was released in Sept 2018, since then Java evolved a lot, see below link for details

• https://en.wikipedia.org/wiki/Java_version_history

Java SE 17 was released in Sept 2021, maybe too early to adopt? I check the code with Java SE 17, since Nashorn was removed in Java SE 15, a tiny code change is required

• https://openjdk.java.net/jeps/372 Nashorn was removed

This may also related with issue #61 , because with a modern build system it is easy to add a dependency.

[digama0]

Java 9+ broke compound undo, which is bad enough that I generally recommend downgrading in order to use mmj2. Maybe they have a better solution now, but last time I checked they removed the feature which let you undo more than one character at a time, which makes the text view pretty painful to use.

https://github.com/digama0/mmj2/blob/8f49fb2c93531c5c75fcb65886837c8d0617c033/src/mmj/pa/CompoundUndoManager.java#L128-L132

(Note: The Netbeans bugzilla appears to be dead; the relevant archive link is https://bz.apache.org/netbeans/show_bug.cgi?id=270142 .)

[mountain]

Thanks for the feedback, let me check this.

[mountain]

@digama0 I check with JDK 17, compound undo works, but with one extra line break?

JDK settings

Before editing, see the caret position

Add some characters

Invoke CTRL-Z

I do see compound undo worked, but with an extra line break.

[mountain]

If this issue was solved, we may switch develop environment to latest JDK but stick release version of the jar to JDK 11.

But let me check above on JDK 11....

emm, it also works. Is my test not correct?

[mountain]

@digama0 I had checked with JDK 11 on more complex cases, the undo works.

Could you double check this, or give the test details to reproduce the bug? If I have the details on how to reproduce, I can investigate the problem.

Mingli

[mountain]

OK, I just found this

• https://groups.google.com/g/metamath/c/WFoQTXy17lU

Giving clue on how to reproduce, let me check hitting CTRL-U and CTRL-R

Check the JDK version

The params

LoadFile,/Users/mingli/Metamath/set.mm/set.mm
VerifyProof,*
Parse,*
ProofAsstUnifySearchExclude,biigb,xxxid,dummylink
ProofAsstProofFolder,/Users/mingli/Metamath/work
TheoremLoaderMMTFolder,/Users/mingli/Metamath/work
RunProofAsstGUI

Test new Proof

PA Window first appeared

click menu item New Proof

input a1i and then Enter, the first try was succeeded.

Test Unification and Reformat

Start again

input ax-mp

Hit CTRL-U

Hit CTRL-R

Are the above correct?